Attention is currently required from: jolly, osmith.

Patch set 4:Code-Review -1

View Change

1 comment:

• Patchset:

  • Patch Set #4:

    I think it is dangerous to have the nvstate.bin in this patch. We should generate the nvstate.bin dynamically using a script before the test runs.

    The problem is that when we make changes to some of the structs that make up the nvstate.bin file, we may end up with errors which may be difficult to find. In the best case, the IPAd will reject de-serializing the nvstate in the worst case (if we have not increased the version) there might be unexpected behavior.

    Let's add a mechanism that generates the nvstate.bin before each testrun.

To view, visit change 42967. To unsubscribe, or for help writing mail filters, visit settings.