arehbein has uploaded this change for review.

View Change

Include constants for cross component defaults (RLC)

Required change: Ie83a0160aed303e2a6d1a90e581770d1087b22ed

Change-Id: I08322563aa508e2fc6c8af9d1997b68a998aaaca
---
M src/osmo-bsc/net_init.c
1 file changed, 22 insertions(+), 11 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/79/31879/1

diff --git a/src/osmo-bsc/net_init.c b/src/osmo-bsc/net_init.c
index 446a5d5..5116199 100644
--- a/src/osmo-bsc/net_init.c
+++ b/src/osmo-bsc/net_init.c
@@ -48,17 +48,17 @@
 	{ .T = 3119, .default_val = 10, .desc = "(unused)" },
 	{ .T = 3122, .default_val = GSM_T3122_DEFAULT, .desc = "Wait time after RR Immediate Assignment Reject" },
 	{ .T = 3141, .default_val = 10, .desc = "(unused)" },
-	{ .T = 3142, .default_val = 20,
+	{ .T = 3142, .default_val = NM_PAR_T3142_DEFAULT,
 	  .desc = "Used during packet access on CCCH/while in dedicated mode. Started after the receipt of "
 		  "IMMEDIATE ASSIGNMENT REJECT or DTM REJECT or EC IMMEDIATE ASSIGNMENT REJECT",
 	  .max_val = UINT8_MAX },
-	{ .T = 3169, .default_val = 5,
+	{ .T = 3169, .default_val = NM_PAR_T3169_DEFAULT,
 	  .desc = "Release radio resource (TFI, USF) timer (linked to N3103, N3103)", .max_val = UINT8_MAX },
-	{ .T = 3191, .default_val = 5,
+	{ .T = 3191, .default_val = NM_PAR_T3191_DEFAULT,
 	  .desc = "Downlink TBF Release downlink RLC data block retransmission timer", .max_val = UINT8_MAX },
-	{ .T = 3193, .default_val = 1600, .desc = "Downlink TBF Release timer", .unit = OSMO_TDEF_MS,
+	{ .T = 3193, .default_val = NM_PAR_T3193_DEFAULT_MSEC, .desc = "Downlink TBF Release timer", .unit = OSMO_TDEF_MS,
 	  .max_val = UINT8_MAX * 10 },
-	{ .T = 3195, .default_val = 5,
+	{ .T = 3195, .default_val = NM_PAR_T3195_DEFAULT,
 	  .desc = "Timer for TFI release on N3105 overflow (unresponsive MS)", .max_val = UINT8_MAX },
 	{ .T = 3212, .default_val = 5, .unit = OSMO_TDEF_CUSTOM,
 		.desc = "Periodic Location Update timer, sent to MS (1 = 6 minutes)" },
@@ -88,11 +88,11 @@
 			" after this amount of idle time, forget internally cumulated time remainders. Zero to always"
 			" keep remainders. See also X16, X17." },
 	{ .T = -25, .default_val = 5, .desc = "Timeout for initial user data after an MSC initiated an SCCP connection to the BSS" },
-	{ .T = GSM_BTS_TDEF_ID_COUNTDOWN_VALUE_NEG26, .default_val = 15,
+	{ .T = GSM_BTS_TDEF_ID_COUNTDOWN_VALUE_NEG26, .default_val = NM_PAR_COUNTDOWN_VALUE_DEFAULT,
 	  .desc = "CV: Countdown value/remaining blocks to transmit", .unit = OSMO_TDEF_CUSTOM, .max_val = UINT8_MAX },
-	{ .T = GSM_BTS_TDEF_ID_UL_TBF_EXT_NEG27, .default_val = 2500, .desc = "Extended uplink TBF",
+	{ .T = GSM_BTS_TDEF_ID_UL_TBF_EXT_NEG27, .default_val = NM_PAR_UL_TBF_EXT_DEFAULT_MSEC, .desc = "Extended uplink TBF",
 	  .unit = OSMO_TDEF_MS, .max_val = 500 * 10 },
-	{ .T = GSM_BTS_TDEF_ID_DL_TBF_EXT_NEG28, .default_val = 2500, .desc = "Extended downlink TBF",
+	{ .T = GSM_BTS_TDEF_ID_DL_TBF_EXT_NEG28, .default_val = NM_PAR_DL_TBF_EXT_DEFAULT_MSEC, .desc = "Extended downlink TBF",
 	  .unit = OSMO_TDEF_MS, .max_val = 500 * 10 },
 	{ .T = -3105, .default_val = GSM_NY1_DEFAULT, .unit = OSMO_TDEF_CUSTOM,
 		.desc = "Ny1: Maximum number of Physical Information (re)transmissions" },
@@ -103,13 +103,13 @@
 			"paging requests will if possible replace a request in retransmission state from the queue or otherwise be discarded, "
 			"hence limiting the size of the queue and maximum delay of its scheduled requests. "
 			"X3113 also serves as the upper boundary for dynamic T3113 when estimating the expected maximum delay to get a response" },
-	{ .T = GSM_BTS_TDEF_ID_N3101_NEG3169, .default_val = 10,
+	{ .T = GSM_BTS_TDEF_ID_N3101_NEG3169, .default_val = NM_PAR_N3101_DEFAULT,
 	  .desc = "N3101: Maximum USFs without response from the MS", .unit = OSMO_TDEF_CUSTOM, .min_val = GSM_N3101_STRICT_LOWER_BOUND + 1,
 	  .max_val = UINT8_MAX },
-	{ .T = GSM_BTS_TDEF_ID_N3103_NEG3170, .default_val = 4,
+	{ .T = GSM_BTS_TDEF_ID_N3103_NEG3170, .default_val = NM_PAR_N3103_DEFAULT,
 	  .desc = "N3103: Maximum PACKET UPLINK ACK/NACK messages within a TBF unacknowledged by MS",
 	  .unit = OSMO_TDEF_CUSTOM, .max_val = UINT8_MAX },
-	{ .T = GSM_BTS_TDEF_ID_N3105_NEG3171, .default_val = 8,
+	{ .T = GSM_BTS_TDEF_ID_N3105_NEG3171, .default_val = NM_PAR_N3105_DEFAULT,
 	  .desc = "N3105: Maximum allocated data blocks without RLC/MAC control reply from MS", .unit = OSMO_TDEF_CUSTOM, .max_val = UINT8_MAX },
 	{ .T = -3210, .default_val = 20, .desc = "After L3 Complete, wait for MSC to confirm" },
 	{}

To view, visit change 31879. To unsubscribe, or for help writing mail filters, visit settings.