20 comments:
File src/host/layer23/include/osmocom/bb/common/tun.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2782):
Patch Set #1, Line 39: int (*cb_ind) (struct tun_t * tun, void *pack, unsigned len);
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2782):
Patch Set #1, Line 39: int (*cb_ind) (struct tun_t * tun, void *pack, unsigned len);
Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2782):
Patch Set #1, Line 53: int (*cb_ind) (struct tun_t * tun, void *pack,
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2782):
Patch Set #1, Line 53: int (*cb_ind) (struct tun_t * tun, void *pack,
Unnecessary space before function pointer arguments
File src/host/layer23/src/common/apn.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2782):
Patch Set #1, Line 78: memcpy(&dst.u.sin6.sin6_addr, ((uint8_t*)&ip6h->ip6_dst) + pref_offset, 8);
"(foo*)" should be "(foo *)"
File src/host/layer23/src/common/tun.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2782):
Patch Set #1, Line 48: #elif defined (__FreeBSD__)
space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2782):
Patch Set #1, Line 53: #elif defined (__APPLE__)
space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2782):
Patch Set #1, Line 65: #define SYS_ERR(sub, pri, en, fmt, args...) \
Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2782):
Patch Set #1, Line 104: #if defined(__FreeBSD__) || defined (__APPLE__)
space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2782):
Patch Set #1, Line 123: #if defined(__FreeBSD__) || defined (__APPLE__)
space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2782):
Patch Set #1, Line 186: #elif defined(__FreeBSD__) || defined (__APPLE__)
space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2782):
Patch Set #1, Line 214: strcpy(ifr.ifr_name, dev_name);
Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY()
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2782):
Patch Set #1, Line 221: strncpy((*tun)->devname, ifr.ifr_name, IFNAMSIZ);
Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY()
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2782):
Patch Set #1, Line 229: } else {
else is not generally useful after a break or return
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2782):
Patch Set #1, Line 230: strncpy((*tun)->devname, dev_name, IFNAMSIZ);
Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY()
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2782):
Patch Set #1, Line 243: #elif defined(__FreeBSD__) || defined (__APPLE__)
space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2782):
Patch Set #1, Line 273: strncpy(areq.ifra_name, (*tun)->devname, IFNAMSIZ);
Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY()
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2782):
Patch Set #1, Line 283: while (ioctl(fd, SIOCDIFADDR, (void *)&areq) != -1) ;
space prohibited before semicolon
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2782):
Patch Set #1, Line 319: int (*cb_ind) (struct tun_t * tun, void *pack, unsigned len))
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2782):
Patch Set #1, Line 319: int (*cb_ind) (struct tun_t * tun, void *pack, unsigned len))
Unnecessary space before function pointer arguments
To view, visit change 30994. To unsubscribe, or for help writing mail filters, visit settings.