Attention is currently required from: fixeria, pespin.

View Change

1 comment:

• File src/m3ua.c:

  • Patch Set #1, Line 503: npar->info_string = talloc_strdup(ctx, xua_msg_part_get_str(info_ie));

    Reading https://talloc.samba.org/talloc/doc/html/group__talloc__string.html#gaca866b920e3b876b00946027244cdd8f I don't understand how this solves the problem. Wouldn't it just run strlen() on info_ie, reading past the end of the "string" if it does not have the null char?

    Wouldn't it be better to reject strings without \0 at the end here, because the "info_string" name implies that it is a string and other code is likely to assume that it is zero-terminated?

To view, visit change 43216. To unsubscribe, or for help writing mail filters, visit settings.