Attention is currently required from: fixeria, keith, neels.
View Change
1 comment:
File src/sip.c:
Patch Set #3, Line 88: sdp_extract_sdp(leg, sip, false);
183 without SDP is apparently also legal.
183 without SDP was handled before already and should not be modified here. We're adding "180 with SDP" here. Or did you want to say "180 without SDP is apparently also legal", i.e. we should accept both 183 and 180 without SDP?
To view, visit change 38039. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: Ia0072080c2e0bfb8b2bf751a248d3410a7723e79
Gerrit-Change-Number: 38039
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge@osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: jolly <andreas@eversberg.eu>
Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu>
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-CC: keith <keith@rhizomatica.org>
Gerrit-Attention: neels <nhofmeyr@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: keith <keith@rhizomatica.org>
Gerrit-Comment-Date: Mon, 07 Oct 2024 17:01:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: keith <keith@rhizomatica.org>