osmith submitted this change.

View Change


Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved
osmo-release: rework cleaning of TODO-RELEASE

Instead of removing all non-comment lines from the existing TODO-RELEASE
file, replace it with a template that is now stored inside the
osmo-release.sh script. This allows modifying the comment lines
consistently across all repositories when making a new release.

Change-Id: I38a40f7a6d71d67acf636ee9a1445db38e3bdf0d
---
M osmo-release.sh
1 file changed, 30 insertions(+), 3 deletions(-)

diff --git a/osmo-release.sh b/osmo-release.sh
index 9edfccd..5d4cb28 100755
--- a/osmo-release.sh
+++ b/osmo-release.sh
@@ -237,6 +237,20 @@
fi
}

+clean_todo_release() {
+ rm -f TODO-RELEASE
+ echo "# When cleaning up this file: bump API version in corresponding Makefile.am and rename corresponding debian/lib*.install" >> TODO-RELEASE
+ echo "# according to https://osmocom.org/projects/cellular-infrastructure/wiki/Make_a_new_release" >> TODO-RELEASE
+ echo "# In short: https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html#Updating-version-info" >> TODO-RELEASE
+ echo "# LIBVERSION=c:r:a" >> TODO-RELEASE
+ echo "# If the library source code has changed at all since the last update, then increment revision: c:r + 1:a." >> TODO-RELEASE
+ echo "# If any interfaces have been added, removed, or changed since the last update: c + 1:0:0." >> TODO-RELEASE
+ echo "# If any interfaces have been added since the last public release: c:r:a + 1." >> TODO-RELEASE
+ echo "# If any interfaces have been removed or changed since the last public release: c:r:0." >> TODO-RELEASE
+ echo "#library what description / commit summary line" >> TODO-RELEASE
+ git add TODO-RELEASE
+}
+

BUMPVER=`command -v bumpversion`
if [ "z$BUMPVER" = "z" ]; then
@@ -281,10 +295,9 @@
fi

set -e
+
if [ -f "TODO-RELEASE" ]; then
- grep '#' TODO-RELEASE > TODO-RELEASE.clean || true
- mv TODO-RELEASE.clean TODO-RELEASE
- git add TODO-RELEASE
+ clean_todo_release
fi

# Add missing epoch (OS#5046)

To view, visit change 37563. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I38a40f7a6d71d67acf636ee9a1445db38e3bdf0d
Gerrit-Change-Number: 37563
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-MessageType: merged