Attention is currently required from: keith.

View Change

5 comments:

• File src/libmsc/db.c:

  • Patch Set #1, Line 314: [DB_STMT_SMS_DEL_SENT_BY_ID] =

    what's the point in having the 2 of them?

• File src/libmsc/gsm_04_11.c:

  • Patch Set #1, Line 871: /* msc_vlr tests will not pass any sms_queue, hence need to check smq != NULL */

    Rather better fix the tests to pass a valid smq pointer.

  • Patch Set #1, Line 873: db_sms_mark_delivered(sms);

    Sounds like all this should be placed wherever S_SMS_DELIVERED signal is handled imho.

• File src/libmsc/sms_queue.c:

  • Patch Set #1, Line 123: struct gsm_sms_queue {

    If you move the code block to be handled in signal callback, this probably can stay here.

  • Patch Set #1, Line 607: /* Remember the subscriber and clear the pending entry */

    The cod eblock should be mover over here?

To view, visit change 28340. To unsubscribe, or for help writing mail filters, visit settings.