Attention is currently required from: pespin.

View Change

2 comments:

• File Transceiver52M/Transceiver.cpp:

  • Patch Set #3, Line 1026: return -EINVAL;

    This logic change looks unrelated to this patch, please split into several patches.

    The logic is preserved here. The different return code is only used to distinguish this case from a normal `0` return value after the function was split. Previously this condition was handled in the same function, so there was no need to differentiate it.

  • Patch Set #3, Line 1091: return rc == -EINVAL ? 0 : rc; /* Ignore invalid values, but report other errors */

    This is a logic change, please split into separate patch.

    The logic is preserved here. Previously, when the timeslot was out of range, the function returned 0. After splitting the function, ctrl_cmd_handle() returns -EINVAL for that case, and ctrl_sock_handle_rx() converts it back to 0 to keep the original behavior.

To view, visit change 42410. To unsubscribe, or for help writing mail filters, visit settings.