Attention is currently required from: dexter, laforge, neels, osmith.

Patch set 1:Code-Review -2

View Change

2 comments:

• Patchset:

  • Patch Set #1:

    The fix is literally commonprefix -> commonpath, but the LLM security spam didn't even get that right.

• File osmo-smdpp.py:

  • Patch Set #1, Line 643: if os.path.commonprefix((os.path.realpath(path),self.upp_dir)) != self.upp_dir:

    Thanks for testing this. I didn't test it. I trusted the report as it seemed plausible. […]

    Olivers test misses the actual issue. 1) realpath in the actual code strips the trailing slash for both paths which makes all the difference here precisely because the commonprefix matches chars and not path parts 2) passwd is not a sibling dir, it only works for a sibling dir.

To view, visit change 42625. To unsubscribe, or for help writing mail filters, visit settings.