Attention is currently required from: laforge, pespin.

View Change

2 comments:

• File src/sbcap/sbcap_common.c:

  • Patch Set #2, Line 162: static char pdu_name[256] = "<unknown>";

    may i suggest the pattern

      int sbcap_pdu_get_name_buf(char *buf, size_t buflen, const ...)
      {
           (this function)
           return sb.chars_needed;
      }

      char *sbcap_pdu_get_name_c(void *ctx, const ... )
      {
           OSMO_NAME_C_IMPL( ... )
      }

    • avoids adding static buf (e.g. via OTC_SELECT)
    • can be used more than once per printf()
    • can be re-used via OSMO_STRBUF_APPEND()

  • Patch Set #2, Line 166: OSMO_STRBUF_PRINTF(sb, "%s", sbcap_procedure_code_str(pc));

    are you sure about: sbcap_procedure_code_str() might return NULL

To view, visit change 28819. To unsubscribe, or for help writing mail filters, visit settings.