Attention is currently required from: jolly.
View Change
1 comment:
Patchset:
Patch Set #1:
Several comments:
- Do we really want to have this configurable over envvar? what's the reasoning? to be able to temporarily spot failures and compare?
- It probably makes sense to change the patch to do the following, to avoid calling io_uring_submit() every loop iteration unconditionally:
- in rubmit_rx, submit_tx, etc, if we had to call io_uring_submit() then set some new global var "io_uring_submit_needed" to true.
- during the poll loop iteration, only call io_uring_submit() if the var was set to true, and set it to false again.
To view, visit change 40489. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id34fe2ced32c63d15b14810e145744f7509064cc
Gerrit-Change-Number: 40489
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas@eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge@osmocom.org>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: jolly <andreas@eversberg.eu>
Gerrit-Comment-Date: Fri, 04 Jul 2025 13:34:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No