pespin submitted this change.

View Change

Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved msuraev: Looks good to me, but someone else must approve
Clarify use RR imm_ass msg fields

Change-Id: I814c7d4c1bce3f56852cfb1c7aa69b41588cb245
---
M src/bts.cpp
1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/bts.cpp b/src/bts.cpp
index 06948d8..646dc76 100644
--- a/src/bts.cpp
+++ b/src/bts.cpp
@@ -667,12 +667,17 @@
int bts_rcv_imm_ass_cnf(struct gprs_rlcmac_bts *bts, const uint8_t *data, uint32_t fn)
{
struct gprs_rlcmac_dl_tbf *dl_tbf = NULL;
+ const struct gsm48_imm_ass *imm_ass = (struct gsm48_imm_ass *)data;
uint8_t plen;
uint32_t tlli;
GprsMs *ms;

- /* move to IA Rest Octets */
- plen = data[0] >> 2;
+ /* Move to IA Rest Octets: TS 44.018 9.1.18 "The L2 pseudo length of
+ * this message is the sum of lengths of all information elements
+ * present in the message except the IA Rest Octets and L2 Pseudo Length
+ * information elements." */
+ /* TS 44.018 10.5.2.19 l2_plen byte lowest 2 bits are '01'B */
+ plen = imm_ass->l2_plen >> 2;
data += 1 + plen;

if ((*data & 0xf0) != 0xd0) {

2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.

To view, visit change 29759. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I814c7d4c1bce3f56852cfb1c7aa69b41588cb245
Gerrit-Change-Number: 29759
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: msuraev <msuraev@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-MessageType: merged