Attention is currently required from: manawyrm.

Patch set 1:Code-Review +1

View Change

1 comment:

• Patchset:

  • Patch Set #1:

    • Conceptually sounds good to me
    • Implementation also looks correct, I couldn't find any execution path that wouldn't do what they should.
    • I'm not 100% sure of the guarantee that the dahdi 'maint' call is supposed to provide to caller ( like is it supposed to be completely "executed" upon return ? ) but even if that was required, I don't see how one would achieve that here anyway so.

To view, visit change 43642. To unsubscribe, or for help writing mail filters, visit settings.