jolly has uploaded this change for review.

View Change

ASCI: Fix wrong check for Null pointer in vgcs_cell_fsm_null()

Fixes: CID#322145, CID#322141
Change-Id: Iec0820f612450cde772076131b07fe7819d35790
---
M src/libmsc/msc_vgcs.c
1 file changed, 13 insertions(+), 3 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/23/33823/1

diff --git a/src/libmsc/msc_vgcs.c b/src/libmsc/msc_vgcs.c
index 8edda6b..1ebfeec 100644
--- a/src/libmsc/msc_vgcs.c
+++ b/src/libmsc/msc_vgcs.c
@@ -2352,12 +2352,12 @@
 		/* Set initial mode. */
 		rtp_stream_set_mode(cell->rtps, MGCP_CONN_RECV_ONLY);
 		/* Commit RTP stream. */
-		if (!cell->bss && !cell->bss->trans) {
-			LOG_CELL(cell, LOGL_DEBUG, "No transaction, cannot continue.\n");
+		if (!cell->bss || !cell->bss->trans) {
+			LOG_CELL(cell, LOGL_DEBUG, "No BSS/transaction, cannot continue.\n");
 			cell_clear(cell, GSM0808_CAUSE_PROTOCOL_ERROR_BETWEEN_BSS_AND_MSC);
 			break;
 		}
-		if (!cell->mgw && !cell->mgw->mgw_ep) {
+		if (!cell->mgw || !cell->mgw->mgw_ep) {
 			LOG_CELL(cell, LOGL_DEBUG, "No MGW endpoint, cannot continue.\n");
 			cell_clear(cell, GSM0808_CAUSE_PROTOCOL_ERROR_BETWEEN_BSS_AND_MSC);
 			break;

To view, visit change 33823. To unsubscribe, or for help writing mail filters, visit settings.