fixeria has uploaded this change for review.

View Change

scheduler: trx_sched_is_sacch_fn(): fix returning non-bool

The function is declared `bool` but returns `-EINVAL` on an error path.
`-EINVAL` is `-22`, which in C implicitly converts to `bool true`.
Returning `false` makes more sense when we don't know the MF layout.

Change-Id: Ib2394687815aed4990c3880446176e4c97440667
---
M src/common/scheduler_mframe.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/08/42508/1

diff --git a/src/common/scheduler_mframe.c b/src/common/scheduler_mframe.c
index 60b6353..647ffc0 100644
--- a/src/common/scheduler_mframe.c
+++ b/src/common/scheduler_mframe.c
@@ -1009,7 +1009,7 @@
 
 	i = find_sched_mframe_idx(ts_pchan(ts), ts->nr);
 	if (i < 0)
-		return -EINVAL;
+		return false;
 	sched = &trx_sched_multiframes[i];
 	frame = &sched->frames[fn % sched->period];
 	if (uplink)

To view, visit change 42508. To unsubscribe, or for help writing mail filters, visit settings.