Attention is currently required from: fixeria, laforge, pespin.
10 comments:
File src/host/layer23/src/mobile/gsm48_rr.c:
Patch Set #3, Line 1331: uint8_t *gcr
`const`
Done
Patch Set #3, Line 1387: uint8_t *gcr
`const`
Done
Patch Set #3, Line 1399: uint8_t *gcr, uint8_t *ch_desc
both `const`
Done
Patch Set #3, Line 1440: return -ENOMEM;
You may be leaking the memory allocated by `asci_notif_alloc()` here. […]
The allocation is not leaked. There is a timer running for every notification. When it times out, the notification is removed from the list. The list is used to notify the upper layer only once and not for every repeated notification received.
The comment states 36 bits, but you allocate (5 * 8) bytes? […]
Right!
Same here, `OSMO_BYTES_FOR_BITS(24)`, because: […]
Done
This is going to break the logstring formatting, better use just one `\n`.
Done
Patch Set #3, Line 1482: if (chd_bv)
`bitvec_free()` is NULL safe, so these checks are redundant.
Done
Patch Set #3, Line 1494: msgb_l3len(msg) - sizeof(*sgh);
Is it guaranteed by the caller that `msgb_l3len(msg)` is always `>= sizeof(*sgh)`? […]
Yes it is. The header is checked in the calling function. Here the header is skipped for getting the payload.
Patch Set #3, Line 1519: msgb_l3len(msg) - sizeof(*nn);
Same here.
There is no check. I will submit another patch that checks the existence of the header for all CCCH messages. This will ensure that at least the NCH header exits in the message.
To view, visit change 34530. To unsubscribe, or for help writing mail filters, visit settings.