Attention is currently required from: pespin.

View Change

7 comments:

• File include/osmocom/bsc_nat/bssap.h:

  • Patch Set #2, Line 30: struct bssmap_assignment_rqst {

    bssmap_ass_req?

    Done

  • Patch Set #2, Line 47: struct bssmap_assignment_complete {

    bssmap_ass_compl?

    Done

• File src/osmo-bsc-nat/bssap_conn.c:

  • Patch Set #2, Line 69: static int bssmap_cn_handle_assignment_rqst(struct subscr_conn *subscr_conn, struct msgb *msg, unsigned int length)

    bssmap_cn_handle_ass_req?

    Done

• File src/osmo-bsc-nat/subscr_conn.c:

  • Patch Set #2, Line 32: int subscr_conn_get_next_id(enum subscr_conn_id_type id_type)

    I'd rather split in 3 functions, using a macro if necessary.

    Done

• File src/osmo-bsc-nat/subscr_conn_fsm.c:

  • Patch Set #2, Line 72: case SUBSCR_CONN_FSM_EV_BSSMAP_CLEAR_COMMAND:

    missing break. Probably not affecting in behavior but I don't see an intended fall-through here.

    This was intentional, but added a break to make it explicit.

  • Patch Set #2, Line 172: static int tx_assignment_request_to_ran(const struct subscr_conn *subscr_conn)

    If possible please move helper functions to the top, and put all the state FM functions together.

    Done

  • Patch Set #2, Line 351: ,

    nice style to lose one an extra line for no good reason :D (j/k)

    Neels invented this, but I like how it's diff friendly :)

To view, visit change 27712. To unsubscribe, or for help writing mail filters, visit settings.