Attention is currently required from: msuraev.

4 comments:

Patchset:
- Patch Set #6:
  It would be great if you explain where is this going to be used and the need for it.
File include/osmocom/core/sockaddr_str.h:
- Patch Set #6, Line 63: #define OSMO_SOCKADDR_STR_FMT_ARGS(R) \
  You could actually define these based on the ones below now.
  It actually makes more sense to swap the order of the 2 groups probably anyway.
File src/sockaddr_str.c:
- Patch Set #6, Line 565: ret = snprintf(buf, rem, "(");
  FYI, you can have a look at using OSMO_STRBUF APIs, they are useful to implement stuff like done in this function.
- Patch Set #6, Line 578: OSMO_SOCKADDR_STR_NO_PORT_FMT_ARGS(sa_str[i]), after);
  maybe add a boolean print_ports to decide whether to add ports or not?

To view, visit change 28992. To unsubscribe, or for help writing mail filters, visit settings.