Attention is currently required from: neels, msuraev.
Patch set 8:Code-Review -1
View Change
1 comment:
Patchset:
Patch Set #8:
I also think it's not entirely customary to log the size of each message we're sending. This can easily be done with wireshark, or with a debugger/tracepoint or (like I'd do it these days) some kind of bfptrace program attached to the specific funciton. the latter can even draw you nice histogram of message sizes with something like 5 lines of code. At zero overhead for the normal non-debug use case.
To view, visit change 29085. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I4d7fc44fde5b900907ec5ebec0450040a764802a
Gerrit-Change-Number: 29085
Gerrit-PatchSet: 8
Gerrit-Owner: msuraev <msuraev@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-Attention: neels <nhofmeyr@sysmocom.de>
Gerrit-Attention: msuraev <msuraev@sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Aug 2022 05:40:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment