Attention is currently required from: fixeria.

View Change

2 comments:

• File pySim/esim/saip/personalization.py:

  • Patch Set #4, Line 61: @abc.abstractmethod

    Why are you removing this? The COMMIT_MSG says you're dropping `ClassVarMeta`, but you're also remov […]

    i commented on this on the subsequent commit, TL;DR: no noticeable difference and no need to have it.

    If you insist i can put back the @abc.abstractmethod decorator.
    Can you explain why is @abstractmethod not a python built-in!?

    (The ClassVarMeta is not something I am willing to bring back, see below.)

  • Patch Set #4, Line 147: class SdKeyScp80_01(SdKey, kvn=0x01, key_type=0x88, permitted_len=[16,24,32]): # AES key type

    IMO, the old approach is much more compact and thus more readable.

    IMHO absolutely not.
    All members in one line?

    With future extensions in upcoming patches, it will look like this

        class SdKeyScp81_01Psk(SdKeyScp81_01, is_abstract = False, name = 'SCP81.01-PSK',
                 key_id = 0x01, key_type = KeyType.tls_psk # 0x85, key_usage_qual = 0x3C):
             pass
             
    you cannot seriously prefer that.

    So let's make it more readable

    
        class SdKeyScp81_01Psk(SdKeyScp81_01, 
                is_abstract = False,
                name = 'SCP81.01-PSK',
                key_id = 0x01,
                key_type = KeyType.tls_psk, # 0x85
                key_usage_qual = 0x3C):
             pass
             
    Congratulations, that is almost standard python, but messed up. I prefer a million times:

        class SdKeyScp81_01Psk(SdKeyScp81_01):
            is_abstract = False
            name = 'SCP81.01-PSK'
            key_id = 0x01
            key_type = KeyType.tls_psk # 0x85
            key_usage_qual = 0x3C
            
    It's standard, shorter, doesn't need messing with the builtin __new__() method.
    Complete no-brainer to me.

To view, visit change 39741. To unsubscribe, or for help writing mail filters, visit settings.