pespin has uploaded this change for review.

View Change

bssgp: Fix non-uniqe rate_ctr ids

Fixes following error:
"""
counter group 'bssgp:bss_ctx' already exists for index 0, instead using index 211. This is a software bug that needs fixing. (rate_ctr.c:221)
"""

Related: SYS#7125
Change-Id: I782e11a75a8adc10292238fde46bf9c3975d970d
---
M src/gb/gprs_bssgp.c
1 file changed, 1 insertion(+), 2 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/56/41456/1

diff --git a/src/gb/gprs_bssgp.c b/src/gb/gprs_bssgp.c
index d436f0a..e73e94c 100644
--- a/src/gb/gprs_bssgp.c
+++ b/src/gb/gprs_bssgp.c
@@ -216,8 +216,7 @@
 	ctx->bvci = bvci;
 	ctx->nsei = nsei;
 	ctx->is_sgsn = true;
-	/* FIXME: BVCI is not unique, only BVCI+NSEI ?!? */
-	ctx->ctrg = rate_ctr_group_alloc(ctx, &bssgp_ctrg_desc, bvci);
+	ctx->ctrg = rate_ctr_group_alloc(ctx, &bssgp_ctrg_desc, ((uint32_t)nsei << 16) | bvci);
 	if (!ctx->ctrg)
 		goto err_ctrg;
 

To view, visit change 41456. To unsubscribe, or for help writing mail filters, visit settings.