Attention is currently required from: neels, laforge, fixeria.

View Change

1 comment:

• File src/core/logging.c:

  • Patch Set #1, Line 874: target->timezone = timezone;

    The bool vs enum aspect doesn't really affect the aspect raised by pespin, does it? […]

    I don't really understand why you are even thinking about asserting or removing timestamps during logging when you can simply have a VTY command fail to set a given timestamp format when you try to set it, as per what I proposed.

    I see nothing wrong with having a function returning a "rc" while others don't, specially when there's an existing case which shows that the function may fail (because system may not support it).

To view, visit change 32043. To unsubscribe, or for help writing mail filters, visit settings.