Attention is currently required from: neels.

Patch set 10:Code-Review -1

View Change

1 comment:

• File pySim/esim/saip/personalization.py:

  • Patch Set #9, Line 37: class ConfigurableParameter:

    I do not understand what ABC is for; this is an educated "i do not understand" as in, i have yet to […]

    There's no point about discussion whether abstract base classes and the python library are useful or not. They are a standard language feature. OTher code you reference may simply predate it, or the authors had different opinions. We've been using ABC quite a bit in pySim, and it does solve real problems.

    Maybe I don't understand the problem. Can you then please make it very clear what exactly did not work and how it did not work? Do you have your code where you try to use ABC but it fails?

    Basically I see this sequence of events:

    • you try to do something not being familiar with ABC
    • you rewrite the code to avoid ABC and see it as an improvement
    • multiple others, including me as the original author disagree

    What ideally should have happened is a concise example of what exactly you were trying to achieve, and how, and how it failed, so that people with more ABC knowledge can see if it has a solution.

    I just don't think we should merge code refactoring that multiple people consider a step backwards unless the very exact technical reason is crystal clear.

To view, visit change 39741. To unsubscribe, or for help writing mail filters, visit settings.