Attention is currently required from: tnt.

View Change

2 comments:

• File src/ice1usb_proto.h:

  • Patch Set #3, Line 68: int16_t err_acc; /*!< Accumulated error */

    I think it might make sense to add a comment that this field was added by firmware version `git describe` of the hardware/firmware git repo.

• File src/usb.c:

  • Patch Set #3, Line 715: "Some values will be zeroed\n",

    I don't think we want to send one NOTICE every status_cb. It's perfectly legal (and probably normal for most users) to have older firmwares. So if at all, I think we need to make sure this message is only printed once during osmo-e1d execution.

    Also, the function could benefit from a comment explaining that the len could be shorter in older firmware versions.

To view, visit change 29618. To unsubscribe, or for help writing mail filters, visit settings.