Attention is currently required from: dexter.

View Change

2 comments:

• File src/libosmo-mgcp/mgcp_codec.c:

  • Patch Set #2, Line 440: conn->end.codec = mgcp_codec_find_same(conn, found_same_codec_opposite);

    and each connections has a codec list.

    And each codec in the list is a different object in memory on each connection right?, hence it is duplicated.

     We can not put both into one list since then we would lose the info which side supports what.

    I'm not saying we drop the per-conn list. But the per-conn list would contain pointers to a global structure containing the codec data.

• File src/libosmo-mgcp/mgcp_network.c:

  • Patch Set #4, Line 509: return;

    The caller is not doing anything meaningful with it but maybe it is better to drop the packet than s […]

    ACK. I'm not saying you fix it in this commit, but you should at least not making it worst in this commit.

To view, visit change 32218. To unsubscribe, or for help writing mail filters, visit settings.