Attention is currently required from: fixeria.

View Change

1 comment:

• File src/stream_srv.c:

  • Patch Set #4, Line 258: return 0;

    Maybe just change to `void`?

    No, I prefer keeping with a return in case we want to add some sort of param check or set it through setsockopt at the future, etc.
    We are already hit by some APIs which were not returning an error code initially and now are left with no information of error despite being able to fail, like osmo_stream_cli_send() (eg. iofd queue going full).

To view, visit change 38894. To unsubscribe, or for help writing mail filters, visit settings.