Attention is currently required from: neels.

View Change

6 comments:

• Commit Message:

  • Patch Set #4, Line 9: Upcoming patches will add handling of arbitrary ftmp strings to

    fmtp strings

  • Patch Set #4, Line 13: Add generic API for handling ftmp strings. The primary intended user is

    fmtp

• Patchset:

  • Patch Set #4:

    Only minor stuff needs improving/fixing, feel free to merge it once you fix those.

• File src/libosmo-mgcp-client/fmtp.c:

  • Patch Set #4, Line 29: for (; fmtp && *fmtp && *fmtp != ';'; fmtp++);

    fmtp being nonull should be checked only once at start.

  • Patch Set #4, Line 41: * if (osmo_sdp_fmtp_get_val(res, sizeof(res), fmtp_vals, "mode-set"))

    IIUC res contains "0,2,4,7" here, maybe worth saying that.

  • Patch Set #4, Line 89: int osmo_sdp_fmtp_get_int(const char *fmtp, const char *option_name, int default_value)

    did you check in SDP spec if int range is enough?

To view, visit change 35434. To unsubscribe, or for help writing mail filters, visit settings.