Attention is currently required from: fixeria.

View Change

1 comment:

• File src/host/layer23/src/modem/rlcmac.c:

  • Patch Set #1, Line 173: rlcmac_prim_l1ctl_alloc

    > ... which alone takes almost the entire line on my screen […]

    I see no real need to expose it, you can simply use the existing API and still fill it afterwards as you please. Some of those alloc APIs doesn't really even let you set all the params, just a few most relevant ones.

    Passing multiple arguments: use multiple lines.

    rlcmac_prim = osmo_gprs_rlcmac_prim_alloc_l1ctl_pdch_data_ind({1,2,3,...});
    rlcmac_prim->l1ctl = ....

To view, visit change 31572. To unsubscribe, or for help writing mail filters, visit settings.