Attention is currently required from: Hoernchen, laforge, osmith.
13 comments:
File doc/manuals/chapters/ipc_if.adoc:
Patch Set #2, Line 42: Once connected, _osmo-trx-ipc_ will submit a `GREETING_REQ` message primitive
(The whole description of the IPC messages could be done with mscgen and diag graphs, like we do in […]
Yeah, it can be improved later on. It's not like the whole procedure is super complex anyway.
Patch Set #2, Line 113: @closed@
this gets printed literally as @closed@ in the pdf, I guess it should be monospace `closed` instead?
I'll use __ since it's not some keyword in the code.
Patch Set #2, Line 116: TIP: See
Maybe move this TIP to the start of the section? Then the reader could open it next to this document […]
I think it's fine having it at the end, otherwise I have the feeling you are redirecting too much the user when entering a section.
But no strong opinion with it though. I think I'll leave it as it is for now.
missing space
Ack
missing space
Done
`
Done
`
Done
``` […]
Done
. Read `buff->data_len` samples, reset the buffer data (`data_len=0``),
increment `next_read` and if read samples is `<N``, continue with next buffer
until `next_read==next_write``, then block again or if timeout elapsed, then we
reach conditon buffer underflow and `return len < N``.
``` […]
Done
``` […]
Done
Patch Set #2, Line 300: next_write was == next_read
is this written as intended, maybe "next_write prev" would be more clear?
Done
. Write samples to `buff = stream->buffers[next_write]`. If `data_len!=0``,
signal `buffer_overflow`` (increase field in stream object) and probably
increase next_read``.
. Increase `next_write``.
. If `next_write was == next_read``, signal the reader through the other
semaphore that it can continue reading.
``` […]
Done
File doc/manuals/chapters/trx-backends.adoc:
* Test and experiment with _osmo-trx-ipc_.
* Write your own IPC _Driver_ connecting to osmo-trx-ipc.
these do not show up as bullet points in the pdf
Done
To view, visit change 36465. To unsubscribe, or for help writing mail filters, visit settings.