Attention is currently required from: fixeria, pespin.

View Change

2 comments:

• File src/libmsc/gsm_04_08_cc.c:

  • Patch Set #1, Line 845: TX Setup with assigned transaction. This is not allowed

    I find this message a bit confusing, maybe say "transaction ID is already assigned"? […]

    done in a separate patch

  • Patch Set #1, Line 847:

    		mncc_release_ind(trans->net, trans, trans->callref,
    				 GSM48_CAUSE_LOC_PRN_S_LU,
    				 GSM48_CC_CAUSE_RESOURCE_UNAVAIL);
    		
    

    Maybe keep this in `gsm48_cc_tx_setup()`? […]

    I've considered it, but `gsm48_cc_tx_setup_set_bearer_cap` which gets split out later also sends `mncc_release_ind` in some (not all!) error code paths. There we can't also keep `mncc_release_ind` in `gsm48_cc_tx_setup`, so for consistency I'll keep it in the split-out functions for now. This is probably something that can be improved in future patches.

To view, visit change 41038. To unsubscribe, or for help writing mail filters, visit settings.