Attention is currently required from: pespin.
View Change
1 comment:
File src/gprs_ms.h:
Patch Set #2, Line 68: _ts
I thought about it already but I'm not sure it's really an improvement since the spec anyway talks a […]
The problem is that '_ts' in this repo is still used for fields holding timeslot number in some places ('_tn' would have been a better fit, IMO), this is why I suggested renaming. Let's see what the others think (ehh, if only we had more people doing code review). This can also be done later, not blocking.
To view, visit change 30575. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I19373939ec104d371e3e91422f018a8175cb0f89
Gerrit-Change-Number: 30575
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-CC: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Fri, 16 Dec 2022 11:32:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>
Gerrit-MessageType: comment