Attention is currently required from: fixeria, fixeria, osmith, pespin.

View Change

1 comment:

• File src/gprs_rlcmac_sched.cpp:

  • Patch Set #2, Line 491: if (bts->trx[trx].fl1h) {

    I think actually the first would be to decouple the feature "direct-phy" from "this bts doesn't supp […]

    When we want to send the information which BTS model is used down to the PCU we might consider to use enum gsm_bts_type_variant:
    https://gitea.osmocom.org/cellular-infrastructure/osmo-bts/src/branch/master/include/osmo-bts/bts.h#L44

    Unfortunately I am not entirely sure how to set this up. The enum is defined in bts.h. We may move it to pcuif_proto.h so that it becomes available to for all entities. Or we just define a new one, but this would be redundant. Any ideas to solve this in a more elegant way? Or is there even something in libosmocore? I couldn't find anything.

    Even more unfotunately: its already a mess, osmo-bsc already has its own definition of that same enum:
    https://gitea.osmocom.org/cellular-infrastructure/osmo-bsc/src/branch/master/include/osmocom/bsc/bts.h#L251

    Maybe it could even have a healthy effect to define that enum in pcuif_proto.h so that we always can be sure that all entities have the same definition.

To view, visit change 34575. To unsubscribe, or for help writing mail filters, visit settings.