neels submitted this change.

View Change


Approvals: neels: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified
ara_m: Fix encoding of DeviceInterfaceVersionDO

Ever since commit 30de9fd8abc9d7c2c541fea7fa4b97c4ca1a54eb in July
we are (properly) using snake_case names in the from_dict (to become
bijective with to_dict). This code was not updated by accident,
creating an exception when using the `aram_get_config`

Change-Id: If216b56b38ab17d13896074aa726278b9ba16923
Related: OS#6119
---
M pySim/ara_m.py
1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/pySim/ara_m.py b/pySim/ara_m.py
index b4ac747..68244d1 100644
--- a/pySim/ara_m.py
+++ b/pySim/ara_m.py
@@ -295,7 +295,7 @@
@staticmethod
def get_config(tp, v_major=0, v_minor=0, v_patch=1):
cmd_do = DeviceConfigDO()
- cmd_do.from_dict([{'DeviceInterfaceVersionDO': {
+ cmd_do.from_dict([{'device_interface_version_do': {
'major': v_major, 'minor': v_minor, 'patch': v_patch}}])
return ADF_ARAM.xceive_apdu_tlv(tp, '80cadf21', cmd_do, ResponseAramConfigDO)


To view, visit change 35230. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: If216b56b38ab17d13896074aa726278b9ba16923
Gerrit-Change-Number: 35230
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge@osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-MessageType: merged