Attention is currently required from: fixeria, pespin.

dexter uploaded patch set #3 to this change.

View Change

The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+2 by pespin

The change is no longer submittable: Code-Review is unsatisfied now.

sndcp_xid: fix length check in gprs_sndcp_compile_xid

The function gprs_sndcp_compile_xid gets an output buffer (dst) and
a length (dst_maxlen), but unfortunately, the length is not checked
before data is written to the output buffer (tlv_put).

The problem was reported by osmocom.org user tsato
(see related ticket)

This patch has been ported from:
osmo-sgsn.git I977946a036f96d4dee2656bef048e2618198db40

Related: OS#7095
Change-Id: I38844155027673d90079c84df5cfd85053f48656
---
M src/sndcp/sndcp_xid.c
M tests/sndcp/sndcp_xid_test.c
M tests/sndcp/sndcp_xid_test.ok
3 files changed, 41 insertions(+), 2 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/62/43962/3

To view, visit change 43962. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I38844155027673d90079c84df5cfd85053f48656
Gerrit-Change-Number: 43962
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>