pespin submitted this change.

View Change


Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved
trxcon: trx_if_cmd_poweron(): send CMD POWERON unconditionally

This works-around a race condition happening when the upper layers
are sending L1CTL RESET.req immediately followed by L1CTL FBSB.req.
The problem is that the TRXC logic is considering the transceiver
powered on until a response to CMD POWEROFF is received.

Change-Id: I967ce047eb198f1eaf8446bb4c1f87a98d3de264
Related: OS#5500
---
M src/host/trxcon/src/trx_if.c
1 file changed, 17 insertions(+), 0 deletions(-)

diff --git a/src/host/trxcon/src/trx_if.c b/src/host/trxcon/src/trx_if.c
index d98bea2..fad1026 100644
--- a/src/host/trxcon/src/trx_if.c
+++ b/src/host/trxcon/src/trx_if.c
@@ -261,8 +261,10 @@

static int trx_if_cmd_poweron(struct trx_instance *trx)
{
+#if 0
if (trx->powered_up)
return -EAGAIN;
+#endif
return trx_ctrl_cmd(trx, 1, "POWERON", "");
}


To view, visit change 33903. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I967ce047eb198f1eaf8446bb4c1f87a98d3de264
Gerrit-Change-Number: 33903
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy@sysmocom.de>
Gerrit-MessageType: merged