Attention is currently required from: pespin, fixeria.

View Change

3 comments:

• File tests/abis/abis_test.c:

  • Patch Set #1, Line 196: SYS#5915

    Same here.

    I think it's fine as used here, the comment makes sense even without (being able to) reading the issue, but it can be useful if somebody wants the additional context.

  • Patch Set #1, Line 235: 5891

    • different issue number?
    • I'd also not mention it here, having it once in the comment makes more sense IMHO

  • Patch Set #1, Line 251: sys5915

    It is still fine to add a suffix to it in case we want to test decoding same message type using diff […]

    Using tickets in the function names seems weird to me. Even if one has access to it, it's not meaningful until looking up the ticket. I'd suggest using test_dec_ipac_dlc_indx() instead, and if we want to do additional tests like you said, then find another (hopefully more descriptive) suffix for those.

To view, visit change 27644. To unsubscribe, or for help writing mail filters, visit settings.