laforge submitted this change.

View Change

Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved
pySim-trace: Fix --no-suppress-{select.status} command line arguments

The Tracer implemented those options and the argparser handled it,
but we didn't ever connect the two.

Change-Id: I7d7d5fc475a8d09efdb63d3d6f1cc1de1996687b
---
M pySim-trace.py
1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/pySim-trace.py b/pySim-trace.py
index 8ee82f3..c480168 100755
--- a/pySim-trace.py
+++ b/pySim-trace.py
@@ -117,8 +117,10 @@
formatter_class=argparse.ArgumentDefaultsHelpFormatter)

global_group = option_parser.add_argument_group('General Options')
-global_group.add_argument('--no-suppress-select', help="Don't suppress displaying SELECT APDUs")
-global_group.add_argument('--no-suppress-status', help="Don't suppress displaying STATUS APDUs")
+global_group.add_argument('--no-suppress-select', action='store_false', dest='suppress_select',
+ help="Don't suppress displaying SELECT APDUs")
+global_group.add_argument('--no-suppress-status', action='store_false', dest='suppress_status',
+ help="Don't suppress displaying STATUS APDUs")

subparsers = option_parser.add_subparsers(help='APDU Source', dest='source', required=True)

@@ -153,7 +155,7 @@
elif opts.source == 'rspro-pyshark-live':
s = PysharkRsproLive(opts.interface)

- tracer = Tracer(source=s)
+ tracer = Tracer(source=s, suppress_status=opts.suppress_status, suppress_select=opts.suppress_select)
logger.info('Entering main loop...')
tracer.main()


To view, visit change 28763. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I7d7d5fc475a8d09efdb63d3d6f1cc1de1996687b
Gerrit-Change-Number: 28763
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge@osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-MessageType: merged