Attention is currently required from: Hoernchen, dexter, lynxis lazus.

View Change

2 comments:

• File pySim/global_platform/__init__.py:

  • Patch Set #1, Line 655:

    (b'\x85' + bertlv_encode_len(len(block)) + block +
                        bytes([len(kcv)]) + kcv)
    

    I would have preferred the use of our object-oriented BER_TLV_IE encoder for the 0x85 as well as some new Transcodable-derived class for the LV KCV section. That would feel more "pysim-onic" to me ,than the low-level byte-concatenation here in a rather high-level method. Or alternatively some kind of costruct.

  • Patch Set #1, Line 1113:

    wouldn't this return more than the three bytes that the comment above indicates? But then, I see, the existing functions above do the same and the truncation happens in the shared compute_kcv() below.

To view, visit change 43136. To unsubscribe, or for help writing mail filters, visit settings.