Attention is currently required from: dexter.
1 comment:
Patchset:
I think this is incompatible with earlier versions of pySim, right? So if somebody has existing scripts to update the MSISDN, it would not work with the new format. I know we did that quite a bit in the early development of pySim-shell days, but today I would say we have many more users and existing manuals / documentations / scripts / ...
At the same time we don't want to prevent improvements.
The best is probably to start some kind of changelog where we document incompatible changes.
Alternatively, at least in this case, we could add some kind of compatibility wrapper. if the caller provides a dict with 'msisdn' as key, we know it's the old format and we could convert that to the new json format before calling the encoder?
To view, visit change 38117. To unsubscribe, or for help writing mail filters, visit settings.