falconia has uploaded this change for review.

View Change

trau_frame.c cosmetic: fix misleading comment

The 4 static const ubit_t arrays ft_hr_up_bits[5], ft_hr_down_bits[5],
ft_data_hr_up_bits[5] and ft_data_hr_down_bits[5] contain frame type
bit patterns that are defined in GSM 08.61 for half-rate speech and
data channels with 16 kbit/s Abis transport, and are used as such
in the code. However, the comment next to them stated incorrectly
that these frame type bit patterns are for 8 kbit/s submultiplexing -
fix it.

Change-Id: Ic2f818a7f8bab4e82f239464511ab430906d4680
---
M src/trau/trau_frame.c
1 file changed, 19 insertions(+), 2 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/84/37284/1
diff --git a/src/trau/trau_frame.c b/src/trau/trau_frame.c
index 9c9baa7..0be005a 100644
--- a/src/trau/trau_frame.c
+++ b/src/trau/trau_frame.c
@@ -82,7 +82,7 @@
TS48060_AMR_FC_NO_SPEECH = 0x0,
};

-/* 16k sub-slots */
+/* GSM 08.60 frame types, 16k sub-slots */
static const ubit_t ft_fr_up_bits[5] = { 0, 0, 0, 1, 0 };
static const ubit_t ft_fr_down_bits[5] = { 1, 1, 1, 0, 0 };
static const ubit_t ft_data_up_bits[5] = { 0, 1, 0, 0, 0 };
@@ -96,7 +96,7 @@
static const ubit_t ft_d145s_bits[5] = { 1, 0, 1, 0, 0 };
static const ubit_t ft_edata_bits[5] = { 1, 1, 1, 1, 1 };

-/* 8k sub-slots */
+/* GSM 08.61 frame types, still on 16k sub-slots */
static const ubit_t ft_hr_up_bits[5] = { 0, 0, 0, 1, 1 };
static const ubit_t ft_hr_down_bits[5] = { 1, 1, 1, 0, 1 };
static const ubit_t ft_data_hr_up_bits[5] = { 0, 1, 0, 0, 1 };

To view, visit change 37284. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Ic2f818a7f8bab4e82f239464511ab430906d4680
Gerrit-Change-Number: 37284
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon@freecalypso.org>
Gerrit-MessageType: newchange