Attention is currently required from: neels.

View Change

1 comment:

• File src/osmo-hnbgw/hnbgw_l3.c:

  • Patch Set #3, Line 281: osmo_plmn_from_bcd(ies->lai.pLMNidentity.buf, &local_plmn);

    a log line here would say something like […]

    I didn't write the details because I expected you to know them better 😄
    So, IIUC the idea here is that we prefer from now on that the user configures the PLMN in the config file, and taking the PLMN on-the-fly from sent/received messages is more like a hack for backward compatibility (may I have understood it wrong?).
    So, the point here is to notify through logging to the user that we are setting the PLMN here dynamically, but that the preferred way would be for them to configure it in the cfg file. This also allows the user to see if what we set dynamically matches their expectations.

    Regarding your examples, I think only the first one is useful to log for the reasons mentioned by me above. Maybe add text to hint the user to update the config file.

To view, visit change 33178. To unsubscribe, or for help writing mail filters, visit settings.