Attention is currently required from: pespin.
View Change
1 comment:
File src/hlr_sms.c:
Patch Set #2, Line 136: char smsc_addr[21];
I find it strange that we don't have any define for this already?
I am not able to find a definition for maximum SMSC-address length anywhere in libosmocore headers.
To view, visit change 34449. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Iaad4531922c41583d261c79f42561a1bdbe03521
Gerrit-Change-Number: 34449
Gerrit-PatchSet: 2
Gerrit-Owner: falconia <falcon@freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Mon, 18 Sep 2023 14:09:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Gerrit-MessageType: comment