Attention is currently required from: laforge, pespin.
11 comments:
Patchset:
IMHO we shouldn't do those more neutral, but rather keep them specific. […]
I hope later patchset revisions are now closer to what we concluded here, so marking as resolved. The question whether to rename `sctp-role (client|server)` is now being discussed in a separate thread.
File include/osmocom/sigtran/osmo_ss7.h:
Patch Set #3, Line 293: bool osmo_ss7_asp_proto_check_trans_proto(enum osmo_ss7_asp_protocol proto, int trans_proto);
Ack, I will drop the `osmo_` prefix and move to `ss7_internal.h`. […]
Done
Patch Set #3, Line 349: struct osmo_ss7_as *osmo_ss7_as_find_by_proto2(struct osmo_ss7_instance *inst,
I added this because internally this function looks for a matching ASP: […]
Done
Patch Set #3, Line 616: osmo_sccp_simple_client2(void *ctx, const char *name, uint32_t default_pc,
Ok, I will revert my changes to the `simple_{server,client}` API and let it use the default transpor […]
Done
File src/osmo_ss7_asp.c:
Patch Set #3, Line 137: case PROTO_MUX(OSMO_SS7_ASP_PROT_IPA, IPPROTO_TCP):
I can do `ipproto << 16`, which would allow for values up to 65535. […]
Actually, we don't need to change anything here because by doing:
```((trans_proto << 8) | (asp_proto << 0))```
we leave one byte and thus 256 unique values for the `asp_proto` (`OSMO_SS7_ASP_PROT_*`), and 3 or 7 bytes for the `trans_proto` (depending on the architecture). Does that make sense? Or am I missing something?
Patch Set #3, Line 532: "ASP protocol '%s' is not compatible with transport protocol %d\n",
Ack, I'll then reword as follows: […]
Done
File src/osmo_ss7_vty.c:
Patch Set #3, Line 65: #define IPPROTO_VAR_STR "([sctp]|[tcp])"
I will see what I can do here, but I am really not getting what's so special about using this syntax […]
I implemented the optional transport protocol parameter using aliases.
Marking as resolved.
Patch Set #3, Line 995: DEFUN_ATTR(sctp_role, asp_sctp_role_cmd,
> Why don't have "transport-protocol (sctp|tcp)" command around here? […]
Done in a separate change:
https://gerrit.osmocom.org/c/libosmo-sccp/+/35978 VTY: rename 'sctp-role' to 'transport-role', add an alias
Patch Set #3, Line 1641: get_value_string(ipproto_vals, asp->cfg.trans_proto),
Ack
Done
File src/xua_rkm.c:
Patch Set #1, Line 240: M3UA-over-SCTP or M3UA-over-TCP? Can we use asp->cfg.proto maybe?
The XUA vs IPA has significant differences in the layer on top of TCP/SCTP which back the fact of ha […]
This is no longer a relevant question, marking thread as resolved.
File tests/vty/ss7_asp_test.vty:
well, the fact that it shows up in a VTY transcript test means (to my understanding) that loading an […]
Done
To view, visit change 35796. To unsubscribe, or for help writing mail filters, visit settings.