laforge submitted this change.

View Change


Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved
euicc: the ICCID TLV object uses bcd-swapped-nibble encoding

Change-Id: I050f9e0fb128f3e1d472e2330b136a753794a5a1
---
M pySim/euicc.py
1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/pySim/euicc.py b/pySim/euicc.py
index c74ca66..58d19f1 100644
--- a/pySim/euicc.py
+++ b/pySim/euicc.py
@@ -149,7 +149,7 @@
class NotificationAddress(BER_TLV_IE, tag=0x82):
_construct = Utf8Adapter(GreedyBytes)
class Iccid(BER_TLV_IE, tag=0x5a):
- _construct = HexAdapter(GreedyBytes)
+ _construct = BcdAdapter(GreedyBytes)
class NotificationMetadata(BER_TLV_IE, tag=0xbf2f, nested=[SeqNumber, ProfileMgmtOperation,
NotificationAddress, Iccid]):
pass

To view, visit change 35252. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I050f9e0fb128f3e1d472e2330b136a753794a5a1
Gerrit-Change-Number: 35252
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge@osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-MessageType: merged