Attention is currently required from: daniel, fixeria, laforge.
View Change
1 comment:
Patchset:
Patch Set #2:
API users that may not expect/want this
Then it's a bug in the users of the API.
I don't think it's bad that by default the ctx of the msg is the one configured in osmo_iofd. We already have multiple releases of osmo_iofd with the previous behavior, so yet another reason not to change that.
In any of the cases, this patch is about fixing a msgb coming from *stream* object, not iofd object. Again, it always worked like that since new APIs related to osmo_iofd implementation were introduced, so changing that now is also problematic for something I think is fine as is now.
To view, visit change 40327. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I69f80f611c14db2b328dafd4a90247c6f2dac6fd
Gerrit-Change-Number: 40327
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann@sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: daniel <dwillmann@sysmocom.de>
Gerrit-Comment-Date: Tue, 27 May 2025 12:28:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>
Comment-In-Reply-To: pespin <pespin@sysmocom.de>