Attention is currently required from: canghaiwuhen.

Patch set 5:Code-Review -1

View Change

5 comments:

• Commit Message:

  • Patch Set #5, Line 7: Some older modules, such as the Air20X module, may crash during PDP attachment due to excessively long QoS response packets.

    Missing first line with acceptable length. You are writing the whole description in the first line.

• File src/sgsn/gprs_gmm.c:

  • Patch Set #5, Line 1339: } else {

    All changes in this file are totally unrelated to those of QoS.
    Submit a separate patch for individual code review.

  • Patch Set #5, Line 1340: /* [FIX] Known IMSI context. If the module initiates an Attach, it means it has restarted and lost its PDP state.

    These lines are too long, split them.

  • Patch Set #5, Line 1344: LOGMMCTXP(LOGL_NOTICE, ctx, "Re-Attach: Dropping stale PDP context for NSAPI=%u\n", pdp->nsapi);

    Line too long.

• File src/sgsn/gprs_sm.c:

  • Patch Set #5, Line 209: //msgb_lv_put(msg, sizeof(default_qos), (uint8_t *)&default_qos);

    This line can be removed, since you are replacing it.

To view, visit change 42050. To unsubscribe, or for help writing mail filters, visit settings.