Attention is currently required from: neels, laforge.

View Change

1 comment:

• File src/libmsc/sdp_msg.c:

  • Patch Set #1, Line 271: if (!sdp_audio_codec_is_set(codec))

    the previous code did not check if codec->subtype was a valid pointer at all, and unconditionally de […]

    """
    #define foreach_sdp_audio_codec(/* struct sdp_audio_codec* */ CODEC, \
    				/* struct sdp_audio_codecs* */ AC) \
    	for (CODEC = (AC)->codec; \
    	     (CODEC - (AC)->codec) < OSMO_MIN((AC)->count, ARRAY_SIZE((AC)->codec)); \
    	     CODEC++)

    """

    """
    bool sdp_audio_codec_is_set(const struct sdp_audio_codec *a)
    {
    	return a && a->subtype_name[0];
    }
    """

    Can "codec" be really NULL here? I don't think so (maybe if &sdp->audio_codecs->codec==NULL, but is that really possible?)

To view, visit change 30111. To unsubscribe, or for help writing mail filters, visit settings.