Attention is currently required from: laforge, neels.

View Change

1 comment:

• File src/osmo-hnbgw/hnbgw_rua.c:

  • Patch Set #2, Line 313: tx_disconnect:

    I find this goto here not really useful and adding complexity to the code, since it's only used in one code path and the function above has no general "return" statement just above.

    I'd say either move this entire code block directly where it belongs, or put it in a static helper function and call it in the code path where it belongs.

To view, visit change 37807. To unsubscribe, or for help writing mail filters, visit settings.