Attention is currently required from: manawyrm, laforge, tnt.
Patch set 1:Code-Review +1
View Change
1 comment:
Patchset:
Patch Set #1:
Looks fine, but :
- Why is that needed ? I don't see it used in subsequent patches (yet) ?
- I'm wondering if 'len' should be ssize_t just for consitency. (I know it can't be size_t because we use -1 as special case which for 'size' is not an option). But that's mostly cosmetic as we'll never have packets larger than 2 GB 😊
To view, visit change 27578. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: I5088a5213d2945fdfaf3b242a63e35d0ed511914
Gerrit-Change-Number: 27578
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge@osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: manawyrm <osmocom.account@tbspace.de>
Gerrit-Reviewer: tnt <tnt@246tNt.com>
Gerrit-Attention: manawyrm <osmocom.account@tbspace.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: tnt <tnt@246tNt.com>
Gerrit-Comment-Date: Mon, 28 Mar 2022 08:28:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment