Attention is currently required from: pespin.

Patch set 2:Code-Review +1

View Change

2 comments:

• Patchset:

  • Patch Set #2:

    I didn't try it out, but it looks technically ok to me.

• File src/libosmo-mgcp/mgcp_network.c:

  • Patch Set #2, Line 723: * boundaries. This function is used to convert between the two modes */

    Since this function was static before there was not doxygen apidoc added. Maybe you can add Apidoc now so that it is uniform. Maybe its also good to prefix the function with mgcp_ so that it is like the other functions in this file.

To view, visit change 29867. To unsubscribe, or for help writing mail filters, visit settings.